[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102358#comment-17102358
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
jujoramos commented on pull request #5049:
URL: https://github.com/apache/geode/pull/5049#issuecomment-625698246
> My concern with this is that CacheConfig.SEPARATOR is a public field of a
non-internal class, and as such removing it altogether might be a breaking
change. Perhaps deprecating it and suggesting Region.SEPARATOR be used instead
is the best compromise?
Good call, didn't realise `CacheConfig` is not part of an `internal` package
(I was mistakenly thinking about the one in
`org.apache.geode.internal.cache`)... I'm fine with deprecating the fild, or
just leaving it as it is to directly reference `Region.SEPARATOR`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
