[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102112#comment-17102112
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
DonalEvans commented on pull request #5049:
URL: https://github.com/apache/geode/pull/5049#issuecomment-625553877
> Considering that the `CacheConfig.SEPARATOR` field is now _**only used
within**_ the `CacheConfig` class and _**only in one single method**_, would it
be feasible to directly remove it and always use `Region.SEPARATOR` across the
code base?.
My concern with this is that `CacheConfig.SEPARATOR` is a public field of a
non-internal class, and as such removing it altogether might be a breaking
change. Perhaps deprecating it and suggesting `Region.SEPARATOR` be used
instead is the best compromise?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
