[
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097480#comment-17097480
]
ASF GitHub Bot commented on GEODE-7667:
---------------------------------------
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r418615057
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##########
@@ -1914,9 +1921,10 @@
public static final String REMOVE__MSG__KEY_EMPTY = "Key is Null";
public static final String REMOVE__MSG__REGION_NOT_FOUND = "Region <{0}> Not
Found";
public static final String REMOVE__MSG__KEY_NOT_FOUND_REGION = "Key is not
present in the region";
- public static final String REMOVE__MSG__CLEARED_ALL_CLEARS = "Cleared all
keys in the region";
- public static final String
REMOVE__MSG__CLEARALL_NOT_SUPPORTED_FOR_PARTITIONREGION =
- "Option --" + REMOVE__ALL + " is not supported on partitioned region";
+ public static final String REMOVE__MSG__CLEARED_ALL_KEYS = "Cleared all keys
in the region";
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GFSH commands - uniform gfsh command to clear regions
> -----------------------------------------------------
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
> Issue Type: Sub-task
> Components: regions
> Reporter: Nabarun Nag
> Assignee: Benjamin P Ross
> Priority: Major
> Labels: GeodeCommons, docs
> Time Spent: 5h
> Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove
> —region=/regionName’.
> * Replace this command with ‘clear region —region=regionName’
> * While executing this gfsh command on partitioned regions, this should call
> the clear() Java API using the gfsh function execution machinery.
> * Point to note is that this command should take into consideration of the
> coordinator selection and how this command is distributed to the members
> Acceptance :
> * There should be ‘clear region —region=/regionName’ gfsh command
> * DUnit tests to verify that command can be executed successfully on
> PartitionedRegion
> * Deprecate the remove command, as remove does not mean clear
> * Unit tests with complete code coverage for the newly written code.
> * Test coverage to when a member departs in this scenario
> * Test coverage to when a member restarts in this scenario
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
