[
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090073#comment-17090073
]
ASF GitHub Bot commented on GEODE-7667:
---------------------------------------
DonalEvans commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r413387539
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ClearRvvLockingDUnitTest.java
##########
@@ -51,7 +51,7 @@
/**
* Test class to verify proper RVV locking interaction between entry
operations such as PUT/REMOVE
- * and the CLEAR region operation
+ * and the CLEAR_REGION region operation
Review comment:
Another accidental rename.
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/cache30/RegionReliabilityTestCase.java
##########
@@ -1341,7 +1341,7 @@ public void run() {
// pass
}
- // CLEAR
+ // CLEAR_REGION
Review comment:
I think that several of these renames were accidentally included when
changing the Cli string. They should be put back how they were.
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
##########
@@ -43,19 +43,20 @@
import org.apache.geode.test.dunit.rules.DistributedRule;
/**
- * Test class to verify proper locking interaction between transactions and
the CLEAR region
+ * Test class to verify proper locking interaction between transactions and
the CLEAR_REGION region
Review comment:
More accidental renames in this file.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
##########
@@ -3509,7 +3509,7 @@ public String toString() {
if (de != null) {
sb.append(" key=").append(de.getKey());
} else {
- sb.append(" <END CLEAR>");
+ sb.append(" <END CLEAR_REGION>");
Review comment:
Accidental rename.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GFSH commands - uniform gfsh command to clear regions
> -----------------------------------------------------
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
> Issue Type: Sub-task
> Components: regions
> Reporter: Nabarun Nag
> Assignee: Benjamin P Ross
> Priority: Major
> Labels: GeodeCommons, docs
> Time Spent: 5h
> Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove
> —region=/regionName’.
> * Replace this command with ‘clear region —region=regionName’
> * While executing this gfsh command on partitioned regions, this should call
> the clear() Java API using the gfsh function execution machinery.
> * Point to note is that this command should take into consideration of the
> coordinator selection and how this command is distributed to the members
> Acceptance :
> * There should be ‘clear region —region=/regionName’ gfsh command
> * DUnit tests to verify that command can be executed successfully on
> PartitionedRegion
> * Deprecate the remove command, as remove does not mean clear
> * Unit tests with complete code coverage for the newly written code.
> * Test coverage to when a member departs in this scenario
> * Test coverage to when a member restarts in this scenario
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
