[
https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248154#comment-16248154
]
ASF subversion and git services commented on GEODE-3872:
--------------------------------------------------------
Commit 36408b72b8a629896842fcc1dcae04c939cccda7 in geode's branch
refs/heads/develop from [~jinmeiliao]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=36408b7 ]
GEODE-3872: simplify the Command result Assert (#1043)
* GEODE-3872: simplify the Command result Assert
> Consolidate GfshShellConnectionRule assertions
> ----------------------------------------------
>
> Key: GEODE-3872
> URL: https://issues.apache.org/jira/browse/GEODE-3872
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, tests
> Reporter: Jared Stewart
> Assignee: Jared Stewart
> Fix For: 1.4.0
>
>
> We have started to accumulate several flavors of _executeCommand_ methods on
> GfshShellConnectionRule that implicitly make certain kinds of assertions.
> (For example, assertions on the command result status or on the output text.)
> It would make the code more maintainable to separate the various assertion
> methods into a separate class and to have a single executeCommand method.
> (See e.g.
> http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
