[
https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247986#comment-16247986
]
ASF GitHub Bot commented on GEODE-3872:
---------------------------------------
jinmeiliao commented on issue #1043: GEODE-3872: simplify the Command result
Assert
URL: https://github.com/apache/geode/pull/1043#issuecomment-343570542
precheckin green
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Consolidate GfshShellConnectionRule assertions
> ----------------------------------------------
>
> Key: GEODE-3872
> URL: https://issues.apache.org/jira/browse/GEODE-3872
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, tests
> Reporter: Jared Stewart
> Assignee: Jared Stewart
> Fix For: 1.4.0
>
>
> We have started to accumulate several flavors of _executeCommand_ methods on
> GfshShellConnectionRule that implicitly make certain kinds of assertions.
> (For example, assertions on the command result status or on the output text.)
> It would make the code more maintainable to separate the various assertion
> methods into a separate class and to have a single executeCommand method.
> (See e.g.
> http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
