[
https://issues.apache.org/jira/browse/GEODE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236549#comment-16236549
]
ASF GitHub Bot commented on GEODE-3895:
---------------------------------------
WireBaron commented on a change in pull request #1001: GEODE-3895: Add
Handshake/Message version byte
URL: https://github.com/apache/geode/pull/1001#discussion_r148652574
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServiceVersionNotFoundException.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache.tier.sockets;
Review comment:
Makes sense, will move this and the other exception
(ServiceLoadingFailureException).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Handshake/Message version byte
> ----------------------------------
>
> Key: GEODE-3895
> URL: https://issues.apache.org/jira/browse/GEODE-3895
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Brian Baynes
> Priority: Major
>
> Add an extra protocol version byte so that the first two bytes will
> (initially) be 110 followed by 1. The '1' byte will be increased when the
> HandshakeRequest or Message changes in such a way that we can't make the
> handshake backward-compatible.
> Ensure that clients on newer versions will have their connections terminated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
