[
https://issues.apache.org/jira/browse/GEODE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234795#comment-16234795
]
ASF GitHub Bot commented on GEODE-3895:
---------------------------------------
galen-pivotal commented on a change in pull request #1001: GEODE-3895: Add
Handshake/Message version byte
URL: https://github.com/apache/geode/pull/1001#discussion_r148393806
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/client/protocol/ClientProtocolServiceLoader.java
##########
@@ -48,6 +49,11 @@ public ClientProtocolService lookupService() {
throw new ServiceLoadingFailureException(
"There is more than one ClientProtocolService implementation found
in JVM; aborting");
}
- return clientProtocolServices.get(0);
+ ClientProtocolService clientProtocolService =
clientProtocolServices.get(0);
Review comment:
We could, if we supported more than one version at this point. But we don't
need to yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Handshake/Message version byte
> ----------------------------------
>
> Key: GEODE-3895
> URL: https://issues.apache.org/jira/browse/GEODE-3895
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Brian Baynes
> Priority: Major
>
> Add an extra protocol version byte so that the first two bytes will
> (initially) be 110 followed by 1. The '1' byte will be increased when the
> HandshakeRequest or Message changes in such a way that we can't make the
> handshake backward-compatible.
> Ensure that clients on newer versions will have their connections terminated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
