[
https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102014#comment-16102014
]
ASF GitHub Bot commented on GEODE-3230:
---------------------------------------
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r129647633
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
@@ -639,29 +639,34 @@ public Result compactOfflineDiskStore(
String errorString = CliStrings.format(
CliStrings.COMPACT_OFFLINE_DISK_STORE__MSG__ERROR_WHILE_COMPACTING_DISKSTORE_0_WITH_1_REASON_2,
diskStoreName, fieldsMessage);
- result = ResultBuilder.createUserErrorResult(errorString);
+ result = ResultBuilder.createUserErrorResult(CliStrings.format(
--- End diff --
This looks to me like it's going to build a strange error message that I
expect will look something like this::
```
An error occurred while doing compaction: "While compacting disk store={0}
{1}. Reason: {2}"
```
I think {0} and {1} will be filled in but not {2}.
> Delete unused commands in CliStrings
> ------------------------------------
>
> Key: GEODE-3230
> URL: https://issues.apache.org/jira/browse/GEODE-3230
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example,
> {{start manager}} has a whole set of associated commands -
> {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}},
> {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere.
> These commands should be deleted to clean up the code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
