[
https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098974#comment-16098974
]
ASF GitHub Bot commented on GEODE-3230:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/651
GEODE-3230: Cleaning up unused (Cli)Strings
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3230)
`CliStrings.java` contained a lot of Strings that were not used anywhere in
the code. In this PR, each of these seemingly unused Strings were examined to
find potential uses of them in the code. Strings that did seem useful were
inserted into the code as needed. Strings that didn't seem to be useful were
deleted. Strings that don't seem to be used, but are used in the closed side,
were preserved and tagged as such.
(Note: An attempt was made to use all Strings that weren't currently being
used in parts of the code that seemed appropriate, but most of these were
removed because they broke tests.)
**Testing Status**: **Precheckin running**
### For all changes:
- [x] JIRA ticket
- [x] PR rebased
- [x] Initial commit is squashed and single
- [x] `gradlew build` runs cleanly
- [x] Tests updated to verify changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3230
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #651
----
commit 06dcd340a33c83cab7b4700a3c56e8fe780d0964
Author: YehEmily <[email protected]>
Date: 2017-07-21T21:29:55Z
GEODE-3230: Cleaning up unused (Cli)Strings
----
> Delete unused commands in CliStrings
> ------------------------------------
>
> Key: GEODE-3230
> URL: https://issues.apache.org/jira/browse/GEODE-3230
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example,
> {{start manager}} has a whole set of associated commands -
> {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}},
> {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere.
> These commands should be deleted to clean up the code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
