zcoo commented on code in PR #2781: URL: https://github.com/apache/fluss/pull/2781#discussion_r3049780653
########## fluss-server/src/main/java/org/apache/fluss/server/zk/ZooKeeperClient.java: ########## @@ -127,11 +129,19 @@ import static java.util.stream.Collectors.toMap; import static org.apache.fluss.metadata.ResolvedPartitionSpec.fromPartitionName; +import static org.apache.fluss.server.zk.ZooKeeperOp.multiRequest; import static org.apache.fluss.utils.Preconditions.checkNotNull; /** * This class includes methods for write/read various metadata (leader address, tablet server * registration, table assignment, table, schema) in Zookeeper. + * + * <p>In some method, 'expectedZkVersion' is used to execute an epoch Zookeeper version check. We + * have the following principals to judge if it's necessary to execute epoch Zookeeper version + * check. If all condition met, we need to execute epoch Zookeeper version check. 1. The method + * create/modify/delete Zk node. 2. It's executed by coordinator server. 3. It is about + * metadata(table/partition/leaderAndIsr) rather than server info or ACL info. 4. The Zk node is + * persistent rather than ephemeral. Review Comment: yes thank you for detailed description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
