wuchong commented on code in PR #2781:
URL: https://github.com/apache/fluss/pull/2781#discussion_r3035277072
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/MetadataManager.java:
##########
@@ -346,7 +349,9 @@ public void completeDeletePartition(long partitionId) {
// delete partition assignments node, which will also delete the
bucket state node,
// so that all the zk nodes related to this partition are deleted.
rethrowIfIsNotNoNodeException(
- () -> zookeeperClient.deletePartitionAssignment(partitionId),
+ () ->
+ zookeeperClient.deletePartitionAssignment(
+ partitionId,
ZkVersion.MATCH_ANY_VERSION.getVersion()),
Review Comment:
ditto, we need the true zk version here.
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/MetadataManager.java:
##########
@@ -399,7 +404,8 @@ public long createTable(
long tableId = zookeeperClient.getTableIdAndIncrement();
if (tableAssignment != null) {
// register table assignment
- zookeeperClient.registerTableAssignment(tableId,
tableAssignment);
+ zookeeperClient.registerTableAssignment(
+ tableId, tableAssignment,
ZkVersion.MATCH_ANY_VERSION.getVersion());
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
