qzyu999 commented on code in PR #474:
URL: https://github.com/apache/fluss-rust/pull/474#discussion_r3037594155
##########
crates/fluss/tests/integration/kv_table.rs:
##########
@@ -632,8 +632,8 @@ mod kv_table_test {
let col_smallint = 32767i16;
let col_int = 2147483647i32;
let col_bigint = 9223372036854775807i64;
- let col_float = 3.14f32;
- let col_double = 2.718281828459045f64;
+ let col_float = std::f32::consts::PI;
Review Comment:
Hi @leekeiabstraction, I just thought these might be some minor fixes to do
along the way, can remove if it doesn't look right.
##########
crates/fluss/tests/integration/log_table.rs:
##########
@@ -738,18 +738,18 @@ mod table_test {
row.set_field(14, col_time_ns);
row.set_field(15, col_timestamp_s);
row.set_field(16, col_timestamp_ms);
- row.set_field(17, col_timestamp_us.clone());
- row.set_field(18, col_timestamp_ns.clone());
+ row.set_field(17, col_timestamp_us);
Review Comment:
Hi @leekeiabstraction, I just thought these might be some minor fixes to do
along the way, can remove if it doesn't look right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
