qzyu999 commented on code in PR #474:
URL: https://github.com/apache/fluss-rust/pull/474#discussion_r3033817091
##########
crates/fluss/src/row/column.rs:
##########
@@ -607,29 +615,50 @@ fn write_arrow_values_to_fluss_array(
)?;
}
DataType::Array(_) => {
- let list_arr =
Review Comment:
Hi @fresh-borzoni, thanks for catching this, I've added changes for this in
c81de6355b5252303ee9bfccf0c3551ac3a1c59c. I've refactored the
`DataType::Array(_)` arm to hoist both the `downcast_ref` and the
`from_arrow_type` resolution entirely out of the element loop. To avoid
duplicating the new hoisted loop for all three Arrow list types, I introduced a
`write_list_elements!` macro. The type checking now correctly happens just once
per array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
