polyzos commented on PR #2809: URL: https://github.com/apache/fluss/pull/2809#issuecomment-4056207257
@platinumhamburg thank you for your thoughtful comments, and these are great catches. I will keep iterating on these. The points 1 and 3 you mentioned should be fairly easy to address, by adding a future handler for 1 and for 3 dding an error check for `pollBatch()` . For point 2 `ScannerManager` probably needs to be passed to `ReplicaManager`. I will make these changes and let me know if you have any other thoughts to improve this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
