platinumhamburg commented on PR #2809: URL: https://github.com/apache/fluss/pull/2809#issuecomment-4052426461
@polyzos Thanks, Gannis. This is a very powerful and inspiring PR. Bringing it in will significantly strengthen Fluss’s out-of-the-box experience and lay an outstanding foundation for some future architectural evolution. However, I have a few small questions. At the moment, it seems there are still three issues: - The close_scanner request currently can’t actually be sent, which means when a scan is terminated early, the server-side scanner can only wait for TTL-based cleanup. - The scanner lifecycle is not integrated into the leader migration / replica deletion flow, which may block replica switching and reclamation. - The server has already encoded scan errors into ScanKvResponse, but the client doesn’t handle these errors at all, and may silently treat real failures as “scan completed”. I noticed the corresponding Copilot review comments were silently closed because I didn’t add any new review notes. I’d like to follow up by adding some thoughts on how to address these points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
