affo commented on code in PR #2506:
URL: https://github.com/apache/fluss/pull/2506#discussion_r2910130092
##########
helm/templates/sts-coordinator.yaml:
##########
@@ -101,6 +105,7 @@ spec:
mountPath: /opt/conf
- name: data
mountPath: /tmp/fluss/data
+ {{- include "fluss.security.sasl.volumeMountPath" . | nindent 12 }}
Review Comment:
Ah no, I also don't like it 😅
That's not what I meant, you could simply template:
```
{{- define "fluss.security.sasl.configName" -}}
{{ include "fluss.fullname" . }}-sasl-jaas-config
{{- end -}}
```
instead of:
```
{{- define "fluss.security.sasl.volumeMountName" -}}
{{- if (include "fluss.security.sasl.plain.enabled" .) }}
- name: sasl-config
secret:
secretName: {{ include "fluss.fullname" . }}-sasl-jaas-config
{{- end }}
{{- end -}}
```
It is a common pattern to template the names, so you are sure that using
`{{- include "fluss.security.sasl.configName" . -}}` in all the places you
reference it you are using the same name, and a change propagates everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
