morazow commented on code in PR #2506:
URL: https://github.com/apache/fluss/pull/2506#discussion_r2908133969


##########
helm/templates/sts-coordinator.yaml:
##########
@@ -101,6 +105,7 @@ spec:
               mountPath: /opt/conf
             - name: data
               mountPath: /tmp/fluss/data
+            {{- include "fluss.security.sasl.volumeMountPath" . | nindent 12 }}

Review Comment:
   Not sure if I like this change, seems it became hard to understand since 
structure also changed by including the template.
   
   Let me know what you think



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to