charlesdong1991 commented on code in PR #433:
URL: https://github.com/apache/fluss-rust/pull/433#discussion_r2899971712
##########
crates/fluss/src/row/compacted/compacted_key_writer.rs:
##########
@@ -47,6 +47,17 @@ impl CompactedKeyWriter {
}
pub fn create_value_writer(field_type: &DataType) -> Result<ValueWriter> {
+ // Key columns are scalar-only. We reject Array/Map/Row explicitly
+ // here, so future complex-type writer support does not
+ // silently widen key semantics.
+ if matches!(
+ field_type,
+ DataType::Array(_) | DataType::Map(_) | DataType::Row(_)
Review Comment:
this applies to all array/map/row, so i understand this PR only adds Array,
but i think better to add all of them.
if there is objection, i can remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
