charlesdong1991 commented on code in PR #433:
URL: https://github.com/apache/fluss-rust/pull/433#discussion_r2899960813
##########
crates/fluss/src/row/compacted/compacted_row_reader.rs:
##########
@@ -103,14 +107,24 @@ impl<'a> CompactedRowDeserializer<'a> {
if Decimal::is_compact_precision(precision) {
// Compact: stored as i64
let (val, next) = reader.read_long(cursor);
- let decimal = Decimal::from_unscaled_long(val,
precision, scale)
- .expect("Failed to create decimal from unscaled
long");
+ let decimal =
Review Comment:
i think we should convert all `expect` to typed errors so malformed array
payload handling does not leave panic backdoors. but
##########
crates/fluss/src/row/compacted/compacted_row_reader.rs:
##########
@@ -103,14 +107,24 @@ impl<'a> CompactedRowDeserializer<'a> {
if Decimal::is_compact_precision(precision) {
// Compact: stored as i64
let (val, next) = reader.read_long(cursor);
- let decimal = Decimal::from_unscaled_long(val,
precision, scale)
- .expect("Failed to create decimal from unscaled
long");
+ let decimal =
Review Comment:
i think we should convert all `expect` to typed errors so malformed array
payload handling does not leave panic backdoor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
