davidradl commented on code in PR #27605:
URL: https://github.com/apache/flink/pull/27605#discussion_r2805108993
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -2526,16 +2526,49 @@ void testCreateFunction() {
.ok(
"CREATE FUNCTION `FUNCTION1` AS
'org.apache.flink.function.function1' LANGUAGE JAVA USING JAR
'file:///path/to/test.jar', JAR 'hdfs:///path/to/test2.jar'");
+ // test create function using artifact
Review Comment:
As the jar tests and the artifact tests are the same with just the ARTIFACT
/JAR keyword different, I suggest either a for loop with the same tests run for
ARTIFACT then JAR or better still a parameterized test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
