pnowojski commented on code in PR #27589:
URL: https://github.com/apache/flink/pull/27589#discussion_r2803424952
##########
flink-core/src/main/java/org/apache/flink/configuration/PipelineOptions.java:
##########
@@ -328,4 +329,25 @@ public enum VertexDescriptionMode {
+ "while still using watermark alignment,
set this parameter to true. "
+ "The default value is false. Note: This
parameter may be "
+ "removed in future releases.");
+
+ @Experimental
+ public static final ConfigOption<Integer> WATERMARK_ALIGNMENT_BUFFER_SIZE =
+ key("pipeline.watermark-alignment.buffer-size")
Review Comment:
Tbh all of them are the same to me, and I think `buffer-size` is a bit more
consistent with other similar config options? Capacity we are only using in the
context of caches based on a quick search that I did. On the other hand,
`ring-` prefix I think will be adding a bit more implementation detail to the
config name. Having it described as `ring` buffer in the docs is one thing, but
if we hardcode this in the config option name, that might be problematic if we
ever refactor/reimplement this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
