Efrat19 commented on code in PR #27589:
URL: https://github.com/apache/flink/pull/27589#discussion_r2797313365
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/CheckpointCoordinatorConfiguration.java:
##########
@@ -281,6 +296,17 @@ public static CheckpointCoordinatorConfigurationBuilder
builder() {
return new CheckpointCoordinatorConfigurationBuilder();
}
+ public long getInitialTriggeringDelay() {
+ return pauseSourcesUntilFirstCheckpoint
+ ? ThreadLocalRandom.current()
+ .nextLong(minPauseBetweenCheckpoints,
minPauseBetweenCheckpoints * 2 + 1)
Review Comment:
Maybe add comment / a variable to reason about this math?
##########
flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/AbstractOperatorRestoreTestBase.java:
##########
@@ -258,6 +258,8 @@ private void restoreJob(ClusterClient<?> clusterClient,
Deadline deadline, Strin
private JobGraph createJobGraph(ExecutionMode mode) {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.enableCheckpointing(500, CheckpointingMode.EXACTLY_ONCE);
+ // todo: review the test and timings
Review Comment:
Nit todo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
