davidradl commented on code in PR #27589:
URL: https://github.com/apache/flink/pull/27589#discussion_r2794497866
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/CheckpointCoordinatorConfiguration.java:
##########
@@ -136,10 +141,19 @@ private CheckpointCoordinatorConfiguration(
!isUnalignedCheckpointsEnabled || maxConcurrentCheckpoints <=
1,
"maxConcurrentCheckpoints can't be > 1 if UnalignedCheckpoints
enabled");
+ // max "in between duration" can be one year - this is to prevent
numeric overflows
+ if (minPauseBetweenCheckpoints > 365L * 24 * 60 * 60 * 1_000) {
Review Comment:
nit : could you have this number as a constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
