davidradl commented on code in PR #27589:
URL: https://github.com/apache/flink/pull/27589#discussion_r2794020224
##########
flink-core/src/main/java/org/apache/flink/configuration/PipelineOptions.java:
##########
@@ -328,4 +329,25 @@ public enum VertexDescriptionMode {
+ "while still using watermark alignment,
set this parameter to true. "
+ "The default value is false. Note: This
parameter may be "
+ "removed in future releases.");
+
+ @Experimental
+ public static final ConfigOption<Integer> WATERMARK_ALIGNMENT_BUFFER_SIZE =
+ key("pipeline.watermark-alignment.buffer-size")
+ .intType()
+ .defaultValue(3)
+ .withDescription(
+ "Controls size of the ring buffer used to smooth
out watermark alignment "
+ + "due to the inherent latency of the
alignment process. Allowed watermarks "
+ + "are announced at the updateInterval and
this means they are often out of date "
+ + "after the round trip. To address this
problem, when pausing consumption of records, "
+ + "max allowed watermark is not checked
against the latest value of the watermark in "
+ + "any given split/source, but against the
oldest value in the ring buffer, that is "
+ + "updated at every updateInterval. This
is the config option that controls "
+ + "the size of the ring buffer. The
default buffer size is 3. Buffer sizes below 2 "
Review Comment:
nit :
`Buffer sizes below 2` -> `Buffer sizes of 1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
