WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1218280732
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java: ########## @@ -0,0 +1,78 @@ +package org.apache.flink.connector.jdbc.dialect.clickhouse; + +import org.apache.flink.connector.jdbc.converter.AbstractJdbcRowConverter; +import org.apache.flink.connector.jdbc.dialect.AbstractDialect; +import org.apache.flink.connector.jdbc.internal.converter.ClickhouseRowConvert; +import org.apache.flink.table.types.logical.LogicalTypeRoot; +import org.apache.flink.table.types.logical.RowType; + +import java.util.EnumSet; +import java.util.Optional; +import java.util.Set; + +/** */ Review Comment: Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved ########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialectFactory.java: ########## @@ -0,0 +1,19 @@ +package org.apache.flink.connector.jdbc.dialect.clickhouse; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.connector.jdbc.dialect.JdbcDialect; +import org.apache.flink.connector.jdbc.dialect.JdbcDialectFactory; + +/** */ Review Comment: Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved ########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/converter/ClickhouseRowConvert.java: ########## @@ -0,0 +1,19 @@ +package org.apache.flink.connector.jdbc.internal.converter; + +import org.apache.flink.connector.jdbc.converter.AbstractJdbcRowConverter; +import org.apache.flink.table.types.logical.RowType; + +/** */ Review Comment: Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
