WenDing-Y commented on code in PR #49:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1210426185


##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java:
##########
@@ -322,6 +325,9 @@ void testBatchSink() throws Exception {
 
     @Test
     void testReadingFromChangelogSource() throws Exception {
+        if (!getMetadata().supportUpsert()) {

Review Comment:
   If I remove this judgment, this test case will fail. I would like to hear 
your opinion on how to handle this issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to