adamsaghy commented on code in PR #5671:
URL: https://github.com/apache/fineract/pull/5671#discussion_r3028396939
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java:
##########
@@ -115,6 +112,7 @@ private void batchUpdateJournalEntries(final
List<SavingsAccountData> savingsAcc
for (SavingsAccountTransactionData savingsAccountTransactionData :
savingsAccountTransactionDataList) {
if (savingsAccountTransactionData.getId() == null &&
!MathUtil.isZero(savingsAccountTransactionData.getAmount())) {
final String key =
savingsAccountTransactionData.getRefNo();
+ final Boolean isOverdraft =
savingsAccountTransactionData.getIsOverdraft();
Review Comment:
This seems unused...
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java:
##########
@@ -67,16 +70,10 @@ public class SavingsSchedularInterestPoster {
public void postInterest() throws JobExecutionException {
if (!savingAccounts.isEmpty()) {
List<Throwable> errors = new ArrayList<>();
- LocalDate yesterday =
DateUtils.getBusinessLocalDate().minusDays(1);
for (SavingsAccountData savingsAccountData : savingAccounts) {
boolean postInterestAsOn = false;
LocalDate transactionDate = null;
try {
- if (isInterestAlreadyPostedForPeriod(savingsAccountData,
yesterday)) {
Review Comment:
why to remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
