awaneetdecoder commented on PR #5671:
URL: https://github.com/apache/fineract/pull/5671#issuecomment-4148631514
@adamsaghy I have addressed all the failing checks:
1. **Replaced `ConcurrentModificationException` with Spring's
`OptimisticLockingFailureException`** — this is semantically correct for
optimistic locking failures, extends `DataAccessException` so it is caught by
the existing handler in `postInterest()`, and satisfies SpotBugs.
2. **Removed unused mock infrastructure from the unit test** — the 4 tests
verify pure logic (updateCounts array checking) and have no dependency on
Spring beans, so no mocks are needed.
3. **Ran both commands locally** — `spotlessApply spotbugsMain spotbugsTest
checkstyleMain checkstyleTest` and `build -x test -x cucumber -x doc` both
passed cleanly. The `:fineract-war:binaryDistTar` failure is a pre-existing
duplicate JAR issue reproducible on `develop` with no changes applied.
Thank you for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
