leonardoalunno commented on PR #5622: URL: https://github.com/apache/fineract/pull/5622#issuecomment-4154762058
Hi @vidakovic , I reviewed the `swagger-brake` report and the breaking changes are exactly the expected result of the DTO modernization we just did: - **R007**: Triggered because we added proper `@NotNull` validation to `restrictedProducts` in the new request DTOs. - **R015**: The `GET` method now properly returns an object (`ProductMixData`) instead of a manually serialized JSON string. - **R014**: The old response payload contained many unused legacy fields (like` officeId`, `clientId`, `transactionId`, etc.). Our new specific response DTOs (`ProductMixCreateResponse`, etc.) are much cleaner and only contain the strictly necessary fields (`productId` and `changes`). Since the API is functionally the same but structurally much cleaner and stricter, I believe these diffs are a positive side-effect of the refactoring. Let me know if we can safely accept them or if you need me to adjust the OpenAPI annotations! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
