leonardoalunno commented on PR #5622: URL: https://github.com/apache/fineract/pull/5622#issuecomment-4149176370
Hi @vidakovic! I've just force-pushed an updated commit addressing all your comments: - API Resource Cleanup: Removed all legacy JSON parsing mechanics (`ApiRequestJsonSerializationSettings`, `DefaultToApiJsonSerializer`) and `PlatformSecurityContext` from `ProductMixApiResource`. - Request DTOs: Refactored the controller methods to use the specific request DTOs (`ProductMixCreateRequest`, `ProductMixUpdateRequest`) directly as parameters, and completely removed the redundant `ProductMixRequest` class. - Response DTOs: Added the `@CommandType` annotations to all response classes. - Naming Conventions: Updated the `@Retry` annotation names in the command handlers (e.g., `commandProductMixCreate`). Let me know if everything looks good or if you need any further adjustments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
