moulendra143 commented on PR #5667: URL: https://github.com/apache/fineract/pull/5667#issuecomment-4149249644
Hi Aman, Yes, sure. Thanks for the suggestion! I will add test cases to cover the different error scenarios for the retrieveApprovalTemplate method and update the pull request soon. Thanks again for your feedback. Best regards, Mouli On Sat, 28 Mar 2026 at 23:14, Aman-Mittal ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java > <https://github.com/apache/fineract/pull/5667?email_source=notifications&email_token=BA52NQRR4XEQTMXBIBQUD5L4TAFPLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBSGU4DCMZXGIYKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJL3QOJPXEZLWNFSXOX3DNRUWG2Y#discussion_r3005097970> > : > > > loanApprovalTemplate = this.loanReadPlatformService.retrieveApprovalTemplate(resolvedLoanId); > + } else { > > I Think You should add some tests for this implementation. > > For the all Errors that it can throw in retrieveApprovalTemplate function. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/5667?email_source=notifications&email_token=BA52NQTNCJNIGADKSPFQS434TAFPLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBSGU4DCMZXGIYKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJPLQOJPXEZLWNFSXOX3ON52GSZTJMNQXI2LPNZZV6Y3MNFRWW#pullrequestreview-4025813720>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BA52NQVYYF3PURCIL5RZADT4TAFPLAVCNFSM6AAAAACW2CRLQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAMRVHAYTGNZSGA> > . > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
