Aman-Mittal commented on code in PR #5696:
URL: https://github.com/apache/fineract/pull/5696#discussion_r3005107526
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanApprovedAmountWritePlatformServiceImpl.java:
##########
@@ -58,6 +59,12 @@ public CommandProcessingResult
modifyLoanApprovedAmount(final Long loanId, final
BigDecimal newApprovedAmount =
command.bigDecimalValueOfParameterNamed(LoanApiConstants.amountParameterName);
+ if (newApprovedAmount.compareTo(loan.getApprovedPrincipal()) == 0) {
Review Comment:
Seems like duplicated code: Make and helper function, and maintain constants
for long strings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
