adamsaghy commented on PR #5696: URL: https://github.com/apache/fineract/pull/5696#issuecomment-4136174823
> > @devi-pathak2263 This PR seems not much to do with [FINERACT-2541](https://issues.apache.org/jira/browse/FINERACT-2541).... > > Thanks for the feedback! > > This is a small follow-up improvement related to [FINERACT-2541](https://issues.apache.org/jira/browse/FINERACT-2541). While reviewing the existing implementation, I noticed that updating the approved amount with the same value still triggers history creation and events. > > This PR adds validation to prevent such no-op updates and includes test coverage for it. > > Please let me know if you’d prefer this to be linked to a separate issue instead. FINERACT-2541 is for external investor related changes... This PR is for loan approval... it's defo not relevant to FINERACT-2541 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
