tiagosune commented on PR #5695: URL: https://github.com/apache/fineract/pull/5695#issuecomment-4135375779
> I believe your change is **OK**. > > I noticed that `IP_HEADER_CANDIDATES` in the corresponding test is defined but never used. Maybe we can define it in `IpAddressUtils` and use it in both `CallerIpTrackingFilter` and `IpTrackingFilterTest` classes, respectively. > > I'm not sure if we should address that last observation within this ticket (changing its scope) or create a new one just for that. > > Don't forget to assign the Jira ticket to yourself, since you just created it. > > I suggest keeping just one commit for this PR; it seems you included an extra blank commit. Thank you for the review and the suggestions! I agree that extracting IP_HEADER_CANDIDATES into IpAddressUtils would improve code reuse and consistency. To keep this PR focused, I suggest creating a separate JIRA ticket for that improvement. I can work on it right after this PR. I also noticed that I don't have permission to assign the JIRA ticket to myself, but I would be happy to take ownership of it. I will clean up the commits as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
