dr-fuch commented on PR #5695: URL: https://github.com/apache/fineract/pull/5695#issuecomment-4130917296
I believe your change is **OK**. I noticed that `IP_HEADER_CANDIDATES` in the corresponding test is defined but never used. Maybe we can define it in `IpAddressUtils` and use it in both `CallerIpTrackingFilter` and `IpTrackingFilterTest` classes, respectively. I'm not sure if we should address that last observation within this ticket (changing its scope) or create a new one just for that. I suggest keeping just one commit for this PR; it seems you included an extra blank commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
