Ambika-Sony commented on code in PR #5665:
URL: https://github.com/apache/fineract/pull/5665#discussion_r2969205414


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java:
##########


Review Comment:
   > same here
   
   Hi @Aman-Mittal,
   
   My apologies for the earlier confusion. A recent rebase onto the 1.15.0 
modular structure accidentally included unrelated files from other modules.
   
   I have now rectified the PR to align strictly with the FINERACT-2494 ticket 
scope. It now contains only:
   
   ApiParameterHelper.java: Optimized regex logic.
   
   ApiParameterHelperTest.java: Added a comprehensive JUnit 5 test suite 
covering command IDs, fields, locale, and pagination.
   
   All unrelated changes have been removed, and the build is successful. Ready 
for re-review!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to