dpogue opened a new pull request, #1637:
URL: https://github.com/apache/cordova-ios/pull/1637

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Should close https://github.com/apache/cordova-ios/issues/686
   
   
   ### Description
   <!-- Describe your changes in detail -->
   `cordova build ios --emulator` was trying to build for a specific simulator 
device (either provided with `--target` or falling back to a default 
simulator). This routinely caused problems for people when it decided to 
default to an old iOS runtime, or the wrong device type.
   
   Xcode support building for a generic "Any iOS Simulator" target, so let's do 
that and only care about the specific device in `cordova run ios`.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Updated existing tests and confirmed they run.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to