dpogue opened a new pull request, #1636: URL: https://github.com/apache/cordova-ios/pull/1636
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> `ios-deploy` does not properly handle deploying to newer iOS versions, and Xcode now includes a built-in `devicectl` tool for this purpose (with the caveat that it does not handle deploying to older iOS versions <17). This also allows us to slowly transition away from requiring a global installation of the `ios-deploy` tool, whose licence prevents its direct inclusion or distribution with cordova-ios. Ref https://github.com/apache/cordova-ios/issues/419 Closes https://github.com/apache/cordova-ios/issues/429 Closes https://github.com/apache/cordova-ios/issues/1594 ### Description <!-- Describe your changes in detail --> Bring in a new [`devicectl`](https://github.com/ios-control/devicectl) library to support using `devicectl` to install and launch apps on connected devices. We keep `ios-deploy` as a fallback. The format of device target identifiers is different between `devicectl` and `ios-deploy` namely in that the UDID from `devicectl` includes a dash. Currently we use that dash to determine (given a target ID) whether to invoke `devicectl` or `ios-deploy` but I'd like to find a way to avoid that. It would be nice to be able to provide something like `--target="My iPhone"` (which `devicectl` will happily support) instead of `--target="lotsOfNumbers"`. ### Testing <!-- Please describe in detail how you tested your changes. --> Manual testing deploying an app to a connected iOS 26 device. Needs more unit tests. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
