GitToTheHub commented on code in PR #1132: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1132#discussion_r2898025456
########## src/ios/CDVWKInAppBrowser.m: ########## @@ -38,6 +38,9 @@ Licensed to the Apache Software Foundation (ASF) under one #define IAB_BRIDGE_NAME @"cordova_iab" +// Common margin for sub views +#define MARGIN 12.0 Review Comment: I'm very glad that you booth mentioned that. I use now `layoutMarginsGuide` for settings constraints which should respect a margin and for spacing between elements I use `constraintEqualToSystemSpacingBelowAnchor:`. This is much cleaner. ########## src/ios/CDVWKInAppBrowser.m: ########## @@ -38,6 +38,9 @@ Licensed to the Apache Software Foundation (ASF) under one #define IAB_BRIDGE_NAME @"cordova_iab" +// Common margin for sub views +#define MARGIN 12.0 Review Comment: I'm very glad that you both mentioned that. I use now `layoutMarginsGuide` for settings constraints which should respect a margin and for spacing between elements I use `constraintEqualToSystemSpacingBelowAnchor:`. This is much cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
