dpogue commented on code in PR #1132: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1132#discussion_r2897178339
########## src/ios/CDVWKInAppBrowser.m: ########## @@ -38,6 +38,9 @@ Licensed to the Apache Software Foundation (ASF) under one #define IAB_BRIDGE_NAME @"cordova_iab" +// Common margin for sub views +#define MARGIN 12.0 Review Comment: Is there some iOS system value that we can use to get the spacing dynamically? I just worry that this value could end up needing to be different for different iOS versions in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
