ppkarwasz commented on code in PR #423:
URL:
https://github.com/apache/commons-release-plugin/pull/423#discussion_r3030072271
##########
.github/workflows/maven.yml:
##########
@@ -15,7 +15,11 @@
name: Java CI
-on: [push, pull_request]
+on:
+ push:
+ branches:
+ - "master"
+ pull_request: {}
Review Comment:
GitHub treats and empty object `{}` and nothing (interpreted as `null`) the
same way.
I prefer `{}`, because it immediately shows that the value is empty and I
don't have to check a couple of lines down (blank lines are ignored).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
