garydgregory commented on code in PR #423:
URL:
https://github.com/apache/commons-release-plugin/pull/423#discussion_r3023482925
##########
.github/workflows/maven.yml:
##########
@@ -15,7 +15,11 @@
name: Java CI
-on: [push, pull_request]
+on:
+ push:
+ branches:
+ - "master"
+ pull_request: {}
Review Comment:
What's the difference between '{}' and nothing like in
https://github.com/apache/logging-log4j2/blob/2.x/.github/workflows/build.yaml ?
##########
.github/workflows/maven.yml:
##########
@@ -15,7 +15,11 @@
name: Java CI
-on: [push, pull_request]
+on:
+ push:
+ branches:
+ - "master"
Review Comment:
The GH docs use single quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
