Kriskras99 commented on code in PR #512:
URL: https://github.com/apache/avro-rs/pull/512#discussion_r2972066848
##########
avro/src/schema/mod.rs:
##########
@@ -784,6 +785,69 @@ impl Schema {
}
Ok(())
}
+
+ /// Derive a name for this schema.
+ ///
+ /// The name is a valid schema name and will be unique if the named
+ /// schemas in this schema have unique names.
+ pub(crate) fn unique_normalized_name(&self) -> Cow<'static, str> {
+ match self {
+ Schema::Null => Cow::Borrowed("n"),
+ Schema::Boolean => Cow::Borrowed("B"),
+ Schema::Int => Cow::Borrowed("i"),
+ Schema::Long => Cow::Borrowed("l"),
+ Schema::Float => Cow::Borrowed("f"),
+ Schema::Double => Cow::Borrowed("d"),
+ Schema::Bytes => Cow::Borrowed("b"),
+ Schema::String => Cow::Borrowed("s"),
+ Schema::Array(array) => {
+ Cow::Owned(format!("a_{}",
array.items.unique_normalized_name()))
+ }
+ Schema::Map(map) => Cow::Owned(format!("m_{}",
map.types.unique_normalized_name())),
+ Schema::Union(union) => {
+ let mut name = format!("u{}", union.schemas.len());
+ for schema in &union.schemas {
+ name.push('_');
+ name.push_str(&schema.unique_normalized_name());
+ }
+ Cow::Owned(name)
+ }
+ Schema::BigDecimal => Cow::Borrowed("bd"),
+ Schema::Date => Cow::Borrowed("D"),
+ Schema::TimeMillis => Cow::Borrowed("t"),
+ Schema::TimeMicros => Cow::Borrowed("tm"),
+ Schema::TimestampMillis => Cow::Borrowed("T"),
+ Schema::TimestampMicros => Cow::Borrowed("TM"),
+ Schema::TimestampNanos => Cow::Borrowed("TN"),
+ Schema::LocalTimestampMillis => Cow::Borrowed("L"),
+ Schema::LocalTimestampMicros => Cow::Borrowed("LM"),
+ Schema::LocalTimestampNanos => Cow::Borrowed("LN"),
+ Schema::Decimal(DecimalSchema {
+ inner: InnerDecimalSchema::Bytes,
+ precision,
+ scale,
+ }) => Cow::Owned(format!("db_{precision}_{scale}")),
+ Schema::Uuid(UuidSchema::Bytes) => Cow::Borrowed("ub"),
+ Schema::Uuid(UuidSchema::String) => Cow::Borrowed("us"),
+ Schema::Record(RecordSchema { name, .. })
+ | Schema::Enum(EnumSchema { name, .. })
+ | Schema::Fixed(FixedSchema { name, .. })
+ | Schema::Decimal(DecimalSchema {
+ inner: InnerDecimalSchema::Fixed(FixedSchema { name, .. }),
+ ..
+ })
+ | Schema::Uuid(UuidSchema::Fixed(FixedSchema { name, .. }))
+ | Schema::Duration(FixedSchema { name, .. })
+ | Schema::Ref { name } => {
+ let name: String = name
+ .to_string()
+ .chars()
+ .map(|c| if c.is_ascii_alphanumeric() { c } else { '_' })
Review Comment:
True, the only thing I can think of is hashing the names but that will make
the names very ugly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
