Kriskras99 commented on code in PR #512:
URL: https://github.com/apache/avro-rs/pull/512#discussion_r2969298418
##########
avro/src/reader/block.rs:
##########
@@ -205,6 +215,43 @@ impl<'r, R: Read> Block<'r, R> {
Ok(Some(item))
}
+ pub(super) fn read_next_deser<T: DeserializeOwned>(
+ &mut self,
+ read_schema: Option<&Schema>,
+ ) -> AvroResult<Option<T>> {
+ if self.is_empty() {
+ self.read_block_next()?;
+ if self.is_empty() {
+ return Ok(None);
+ }
+ }
+
+ let mut block_bytes = &self.buf[self.buf_idx..];
+ let b_original = block_bytes.len();
+
+ let item = if read_schema.is_some() {
+ todo!("Schema aware deserialisation does not resolve schemas yet");
Review Comment:
Follow-up, I've changed it to a panic and a comment. I've also documented on
the builder that setting a reader schema is currently incompatible with the
deserialisation interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
