On Thu, Feb 04, 2016 at 12:50:50PM +0200, Jani Nikula wrote: > Since sequence block v2 the second byte contains flags other than just > pull up/down. Don't pass arbitrary data to the sideband interface. > > The rest may or may not work for sequence block v2, but there should be > no harm done. > > Cc: [email protected] > Signed-off-by: Jani Nikula <[email protected]>
Reviewed-by: Ville Syrjälä <[email protected]> well, as far as it can be reviewed with the crappy specs. > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > index 4775aa5462e8..6f013efba45b 100644 > --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c > @@ -207,7 +207,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi > *intel_dsi, const u8 *data) > gpio = *data++; > > /* pull up/down */ > - action = *data++; > + action = *data++ & 1; > > if (gpio >= ARRAY_SIZE(gtable)) { > DRM_DEBUG_KMS("unknown gpio %u\n", gpio); > -- > 2.1.4 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
