> -----Original Message-----
> From: Intel-xe <[email protected]> On Behalf Of Maarten
> Lankhorst
> Sent: Wednesday, January 21, 2026 7:23 PM
> To: [email protected]; [email protected]
> Cc: Maarten Lankhorst <[email protected]>
> Subject: [i915-rt v5 08/21] drm/i915/display: Make icl_dsi_frame_update use
> _fw
> too
>
> Don't use the dmc lock inside the vblank critical section, not even as last
> call.
Looks Good to me.
Reviewed-by: Uma Shankar <[email protected]>
> Signed-off-by: Maarten Lankhorst <[email protected]>
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c
> b/drivers/gpu/drm/i915/display/icl_dsi.c
> index c8e0333706c1e..1df2f347a13be 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -243,8 +243,8 @@ void icl_dsi_frame_update(struct intel_crtc_state
> *crtc_state)
> else
> return;
>
> - intel_de_rmw(display, DSI_CMD_FRMCTL(port), 0,
> - DSI_FRAME_UPDATE_REQUEST);
> + intel_de_rmw_fw(display, DSI_CMD_FRMCTL(port), 0,
> + DSI_FRAME_UPDATE_REQUEST);
> }
>
> static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)
> --
> 2.51.0
