On Mon, 07 Feb 2022, Ville Syrjala <[email protected]> wrote: > From: Ville Syrjälä <[email protected]> > > The bogus loop from compute_dbuf_slices() was copied into > check_mbus_joined() as well. So this lookup is wrong as well. > Fix it. > > Cc: [email protected] > Fixes: f4dc00863226 ("drm/i915/adl_p: MBUS programming") > Signed-off-by: Ville Syrjälä <[email protected]>
Reviewed-by: Jani Nikula <[email protected]> > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index da721aea70ff..23d4bb011fc8 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -4831,7 +4831,7 @@ static bool check_mbus_joined(u8 active_pipes, > { > int i; > > - for (i = 0; i < dbuf_slices[i].active_pipes; i++) { > + for (i = 0; dbuf_slices[i].active_pipes != 0; i++) { > if (dbuf_slices[i].active_pipes == active_pipes) > return dbuf_slices[i].join_mbus; > } -- Jani Nikula, Intel Open Source Graphics Center
