On Mon, 07 Feb 2022, Ville Syrjala <[email protected]> wrote: > From: Ville Syrjälä <[email protected]> > > Apparently I totally fumbled the loop condition when I > removed the ARRAY_SIZE() stuff from the dbuf slice config > lookup. Comparing the loop index with the active_pipes bitmask > is utter nonsense, what we want to do is check to see if the > mask is zero or not. > > Cc: [email protected] > Fixes: 05e8155afe35 ("drm/i915: Use a sentinel to terminate the dbuf slice > arrays") > Signed-off-by: Ville Syrjälä <[email protected]>
Reviewed-by: Jani Nikula <[email protected]> > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 02084652fe3d..da721aea70ff 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -4848,7 +4848,7 @@ static u8 compute_dbuf_slices(enum pipe pipe, u8 > active_pipes, bool join_mbus, > { > int i; > > - for (i = 0; i < dbuf_slices[i].active_pipes; i++) { > + for (i = 0; dbuf_slices[i].active_pipes != 0; i++) { > if (dbuf_slices[i].active_pipes == active_pipes && > dbuf_slices[i].join_mbus == join_mbus) > return dbuf_slices[i].dbuf_mask[pipe]; -- Jani Nikula, Intel Open Source Graphics Center
