On Thu, 04 Nov 2021, Ville Syrjala <[email protected]> wrote: > +static void i8xx_fbc_program_cfb(struct drm_i915_private *i915) > +{ > + struct intel_fbc *fbc = &i915->fbc; > + > + GEM_BUG_ON(range_overflows_end_t(u64, i915->dsm.start, > + fbc->compressed_fb.start, U32_MAX)); > + GEM_BUG_ON(range_overflows_end_t(u64, i915->dsm.start, > + fbc->compressed_llb.start, U32_MAX));
This is just code movement, but why are we adding GEM_BUG_ON() stuff in display? If the macro is useful beyond gem, it should be called something else. If not, it should not be used in display. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
